From e58bac9e5bec64fedf3b69695237a17980c31a49 Mon Sep 17 00:00:00 2001 From: shinmj Date: Wed, 17 Nov 2021 14:09:11 +0900 Subject: [PATCH] testcase update & sonarqube plugin add --- backend/board-service/build.gradle | 1 + .../cloud/boardservice/service/posts/PostsService.java | 4 +++- .../boardservice/api/posts/PostsApiControllerTest.java | 10 +++++++--- 3 files changed, 11 insertions(+), 4 deletions(-) diff --git a/backend/board-service/build.gradle b/backend/board-service/build.gradle index f19dd1c..bec03be 100644 --- a/backend/board-service/build.gradle +++ b/backend/board-service/build.gradle @@ -1,5 +1,6 @@ plugins { id 'org.springframework.boot' version '2.4.5' + id "org.sonarqube" version "2.7" id 'io.spring.dependency-management' version '1.0.11.RELEASE' // querydsl id 'com.ewerk.gradle.plugins.querydsl' version '1.0.10' diff --git a/backend/board-service/src/main/java/org/egovframe/cloud/boardservice/service/posts/PostsService.java b/backend/board-service/src/main/java/org/egovframe/cloud/boardservice/service/posts/PostsService.java index 1d59551..81466a9 100644 --- a/backend/board-service/src/main/java/org/egovframe/cloud/boardservice/service/posts/PostsService.java +++ b/backend/board-service/src/main/java/org/egovframe/cloud/boardservice/service/posts/PostsService.java @@ -203,7 +203,9 @@ public class PostsService extends AbstractService { /** * 첨부파일 entity 정보 저장 이벤트 발생 */ - sendAttachmentEvent(entity); + if (StringUtils.hasText(entity.getAttachmentCode())) { + sendAttachmentEvent(entity); + } return new PostsResponseDto(entity); } diff --git a/backend/board-service/src/test/java/org/egovframe/cloud/boardservice/api/posts/PostsApiControllerTest.java b/backend/board-service/src/test/java/org/egovframe/cloud/boardservice/api/posts/PostsApiControllerTest.java index 5c791ca..aef21ad 100644 --- a/backend/board-service/src/test/java/org/egovframe/cloud/boardservice/api/posts/PostsApiControllerTest.java +++ b/backend/board-service/src/test/java/org/egovframe/cloud/boardservice/api/posts/PostsApiControllerTest.java @@ -18,14 +18,20 @@ import org.egovframe.cloud.boardservice.domain.board.BoardRepository; import org.egovframe.cloud.boardservice.domain.posts.Posts; import org.egovframe.cloud.boardservice.domain.posts.PostsId; import org.egovframe.cloud.boardservice.domain.posts.PostsRepository; +import org.egovframe.cloud.boardservice.service.posts.PostsService; import org.egovframe.cloud.boardservice.util.RestResponsePage; import org.junit.jupiter.api.AfterEach; import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.Test; +import org.mockito.ArgumentMatchers; +import org.mockito.InjectMocks; +import org.mockito.Mock; +import org.mockito.Mockito; import org.springframework.beans.factory.annotation.Autowired; import org.springframework.boot.context.properties.EnableConfigurationProperties; import org.springframework.boot.test.context.SpringBootTest; import org.springframework.boot.test.web.client.TestRestTemplate; +import org.springframework.cloud.stream.function.StreamBridge; import org.springframework.core.ParameterizedTypeReference; import org.springframework.http.HttpEntity; import org.springframework.http.HttpMethod; @@ -428,7 +434,6 @@ class PostsApiControllerTest { params.put("postsTitle", INSERT_POSTS_TITLE); params.put("postsContent", INSERT_POSTS_CONTENT); params.put("postsAnswerContent", INSERT_POSTS_ANSWER_CONTENT); - params.put("attachmentCode", INSERT_ATTACHMENT_CODE); params.put("noticeAt", INSERT_NOTICE_AT); HttpEntity> httpEntity = new HttpEntity<>(params); @@ -459,7 +464,6 @@ class PostsApiControllerTest { assertThat(entity.getPostsTitle()).isEqualTo(INSERT_POSTS_TITLE); assertThat(entity.getPostsContent()).isEqualTo(INSERT_POSTS_CONTENT); assertThat(entity.getPostsAnswerContent()).isEqualTo(INSERT_POSTS_ANSWER_CONTENT); - assertThat(entity.getAttachmentCode()).isEqualTo(INSERT_ATTACHMENT_CODE); assertThat(entity.getReadCount()).isZero(); assertThat(entity.getNoticeAt()).isEqualTo(INSERT_NOTICE_AT); assertThat(entity.getDeleteAt()).isZero(); @@ -652,7 +656,7 @@ class PostsApiControllerTest { * 테스트 데이터 등록 */ private void insertPosts(Boolean deleteAt) { - log.info("###테스트 데이터 등록"); + log.info("###테스트 데이터 등록"); // 게시물 등록 List list = new ArrayList<>();